-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
press kit: add/link to quick facts 2024 johnr365 #2226
Conversation
✅ Deploy Preview for barolo-time-757cf9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Also agree with the [OUTDATED] or (outdated) etc added to the title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a blocker, but i don't particularly like it 😝
we have a new quick-facts doc https://resilience365.com/monero-quick-facts/ Johnr365 😭 ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can del 2019 pdf
and can change pr title to 2024
press-kit/index.md
Outdated
@@ -120,7 +120,7 @@ meta_descr: meta_descr.presskit | |||
<div class="info-block"> | |||
<h2>{% t press-kit.pressdoc %}</h2> | |||
<div> | |||
<h3><a href="https://www.monerooutreach.org/quick-facts.html">{% t press-kit.quickfacts %}</a></h3> | |||
<h3><a href="Monero_QuickFacts_June_2024.pdf">{% t press-kit.quickfacts %}</a></h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<h3><a href="Monero_QuickFacts_June_2024.pdf">{% t press-kit.quickfacts %}</a></h3> | |
<h3><a href="Monero_QuickFacts_June_2024.pdf">{% t press-kit.quickfacts %} (PDF)</a></h3> |
does this work? - added (PDF)
so people know that its a file. I assume PDF doesn't need to be translated.
otherwise, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Presenting direct link to DL/open a .pdf (especially to our audience) is, at the very least, not very courteous: see https://stackoverflow.com/a/48431884
We can also link people to the .html version hosted on johnr365's e.g. Title (PDF) / .html
*The original is the html link. Lets just do that then people can view johns site in plain text and access the printer friendly versions and such
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pointing to https://resilience365.com/monero-quick-facts/ now. the pdf remains for archival purposes only.
10de300
to
4e8c1a8
Compare
pinging @HardenedSteel for a second look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PDF file (https://resilience365.com/files/QuickFacts.pdf) is easier to read. Its better to link the PDF file instead the web page.
Why? Because its quick facts and needs to be easier to read.
@@ -120,7 +120,7 @@ meta_descr: meta_descr.presskit | |||
<div class="info-block"> | |||
<h2>{% t press-kit.pressdoc %}</h2> | |||
<div> | |||
<h3><a href="https://www.monerooutreach.org/quick-facts.html">{% t press-kit.quickfacts %}</a></h3> | |||
<h3><a href="https://resilience365.com/monero-quick-facts">{% t press-kit.quickfacts %}</a></h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<h3><a href="https://resilience365.com/monero-quick-facts">{% t press-kit.quickfacts %}</a></h3> | |
<h3><a href="https://resilience365.com/files/QuickFacts.pdf">{% t press-kit.quickfacts %} (PDF)</a></h3> |
i think this is what @HardenedSteel suggests.
Linking to our hosted version would be ideal though.
I'm ok with any of them.
A) linking to html
B) linking to external PDF
C) linking to internal PDF
internal PDF:
#2226 (comment)
After some more thought, i think we should leave it linking to the page html page (https://resilience365.com/monero-quick-facts)
|
i will offer some reasons as to why i disagree and favour the .html page:
|
Also, when info is updated, we wont have to keep coming back to mirror it (example: i plan to contact john in regards to updating the node count to match monero.fail's 12000 number) |
@nahuhh - thanks, I've updated the node count to ~12,000 to match the monero.fail number. |
then i think that page needs to be improved, it has to be easy to read for inpatient people and newcomers |
aside from the header, you have
links to pdf follow the credits, and the remainder of the page is a text copy of the pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving w/ external html link
there's still Monero_QuickFacts_June_2024.pdf in the repo, is that ok? |
|
quick fix for the broken monerooutreach link.
we could add "(outdated)" to the title, however this is a translated string, and could complicate things.
#2228
replaces #2189 which adds the 2018 version